[openapi-diff-runner] Support renamed files in breaking change detection#40248
Closed
[openapi-diff-runner] Support renamed files in breaking change detection#40248
Conversation
- Updated command-helpers.ts to return renames separately - Implemented logic to match deletions with additions in the same folder - Updated commands.ts to pass renames to breaking change detection - Updated detect-breaking-change.ts to process renamed files - Fixed all test expectations in command-helpers.test.ts, commands.test.ts, and detect-breaking-change.test.ts Co-authored-by: mikeharder <9459391+mikeharder@users.noreply.github.com>
- Updated comment in test to reflect correct breakdown (2 additions + 1 modification + 1 deletion + 1 rename) - Fixed grammatical consistency (singular/plural agreement) Co-authored-by: mikeharder <9459391+mikeharder@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add new API specification for Azure services
[openapi-diff-runner] Support renamed files in breaking change detection
Feb 8, 2026
Member
|
dup of #40303 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The openapi-diff-runner was treating renamed files as separate additions and deletions, causing unnecessary dummy file creation and incorrect breaking change comparisons.
Changes
Core logic (
command-helpers.ts)renamesarray instead of flattening intoadditions/deletionsrenames: { from: string; to: string }[]Breaking change detection (
detect-breaking-change.ts,commands.ts)renamedSwaggersthrough detection contextExample behavior
Before:
After:
This handles Git-detected renames, case-only folder changes, and add/delete pairs that represent renames.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.